Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate uilib-native #3395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Separate uilib-native #3395

wants to merge 2 commits into from

Conversation

M-i-k-e-l
Copy link
Contributor

@M-i-k-e-l M-i-k-e-l commented Nov 18, 2024 •
edited
Loading

Description

Separate uilib-native (based on #3304)

IMPORTANT: this will cause us to use uilib-native internally - so we'll need to work with node_modules when fixing bugs.

When testing in external project:

  1. Snapshot to use 7.34.1-snapshot.5779
  2. You'll need to copy changes from uilib-native manually because it is not released yet (most important is to copy the lib/react-native.config.js into node_modules/uilib-native)

I am not sure the changes in ios/rnuilib.xcodeproj/project.pbxproj are needed - please make sure they are not breaking 🙏

Changelog

⚠️ Separate uilib-native

Additional info

None

@M-i-k-e-l M-i-k-e-l marked this pull request as ready for review November 18, 2024 13:40
@M-i-k-e-l M-i-k-e-l requested a review from ethanshar November 18, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanshar ethanshar Awaiting requested review from ethanshar

At least 1 approving review is required to merge this pull request.

Assignees

@ethanshar ethanshar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-i-k-e-l @ethanshar